Fix chemprop init with trainer #181
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently a pl.Trainer object can be initialized via
from lightning import pytorch as pl
, but also viaimport pytorch_lightning as pl
. We use methods to get and set params in Chemprop. Unfortunately a Trainer Object is newly initialized upon calling set or update params. However, at this time an Accelerator is already instatiated, which leads to an issue as lightning requires a string. The "get device" function detects via isinstance wether a CPU or GPU accelerator was chosen and will transform this back into a string. The isinstance Method however only works for the lighning import but fails if pytorch_lighning is used.Solution:
To prevent adding pytorch_lighning as a dependency we now enhanced the validation. If a user does not use lightning (but used pytorch_lighning instead) a corresponding value Error will now be raised.